v9: Update cypress to newest version and fix errors #11486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 25, 2021 13:39
…/umbraco/Umbraco-CMS into v9/bugfix/fix_flaky_cypress_test
…0' into v9/bugfix/update-cypress-to-8.6.0 # Conflicts: # tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/scripts.ts
p-m-j
reviewed
Oct 25, 2021
| @@ -18,7 +18,8 @@ context('Stylesheets', () => { | |||
|
|
|||
| cy.umbracoContextMenuAction("action-create").click(); | |||
| cy.get('.menu-label').first().click(); // TODO: Fucked we cant use something like cy.umbracoContextMenuAction("action-mediaType").click(); | |||
|
|
|||
| //We have to wait here till everything is loaded, or worker will throw error | |||
| cy.wait(500); | |||
There was a problem hiding this comment.
instead of magic number, is there something to wait on on e.g. cy.get('.ace_text-input') (default timeout 4 seconds)
There was a problem hiding this comment.
Yea I agree that a magic number is not optimal, will try find something better to wait on 👍 I'll do some detective work 🕵️
There was a problem hiding this comment.
how about cy.get('.ace_text-input')
Or cy.get('input[data-element="editor-name-field"]'); which is probably more relevant for the test.
Zeegaan
commented
Oct 26, 2021
tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/templates.ts
Outdated
Show resolved
Hide resolved
p-m-j
reviewed
Oct 26, 2021
tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/templates.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Content/content.ts
nul800sebastiaan
pushed a commit
that referenced
this pull request
Nov 3, 2021
* fixed flaky macro test and updated cypress version * fixed flaky macro test and updated cypress version * Update package.json * Updated cypress to 8.6 and fixed failing script test * Updated cypress to 8.6 and fixed failing script test * Update package-lock.json * Fixed Scripts and stylesheet tests with proper waits instead of magic numbers * Updated to newest version of cypress and fixed template test * Remove duplicate click * Revert version to 8.4.1 * changed template Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit e9ae567) # Conflicts: # src/Umbraco.Tests.AcceptanceTest/package.json # tests/Umbraco.Tests.AcceptanceTest/package-lock.json
nul800sebastiaan
pushed a commit
that referenced
this pull request
Nov 3, 2021
* fixed flaky macro test and updated cypress version * fixed flaky macro test and updated cypress version * Update package.json * Updated cypress to 8.6 and fixed failing script test * Updated cypress to 8.6 and fixed failing script test * Update package-lock.json * Fixed Scripts and stylesheet tests with proper waits instead of magic numbers * Updated to newest version of cypress and fixed template test * Remove duplicate click * Revert version to 8.4.1 * changed template Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit e9ae567) # Conflicts: # src/Umbraco.Tests.AcceptanceTest/package.json # tests/Umbraco.Tests.AcceptanceTest/package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
How to test
npm install&npm run test